KadasMapCanvasItemManager singleton with Q_GLOBAL_STATIC #218
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@m-kuhn does this looks correct to you? |
for more information, see https://pre-commit.ci
|
@domi4484 suspicion: I don't see any kadas_xxx.dll shared library, assuming it's all built statically (which it is by default) and then the static library is linked into the main kadas.exe and the individual python modules. |
|
@domi4484 can you check with the latest version if it's fixed? |
Yes its fixed thanks! |
domi4484
commented
Jan 20, 2025
m-kuhn
approved these changes
Jan 20, 2025
Good, I think this could also fix other problems and should reduce build time and program size |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.